Allow extra fields in YAML schema modules, add stricter validation#1050
Merged
nathanjmcdougall merged 12 commits intomainfrom Oct 27, 2025
Merged
Allow extra fields in YAML schema modules, add stricter validation#1050nathanjmcdougall merged 12 commits intomainfrom
nathanjmcdougall merged 12 commits intomainfrom
Conversation
nathanjmcdougall
changed the title
datamodel-code-generator from 0.28.2 to 0.35.0
nathanjmcdougall
changed the title
… revert to previous behaviour) and add missing doc comment
Restore addition of "shared" to the Literal annotation in `StepBase.type` to match default
nathanjmcdougall
force-pushed
the
151-how-to-deal-with-out-of-schema-logic
branch
from
0583a81 to
e7698a2
Compare
CodSpeed Performance ReportMerging #1050 will not alter performanceComparing Summary
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables extra fields in YAML schema modules by adding extra="allow" to Pydantic model configurations, while also implementing stricter validation and improving roundtripping capabilities. The changes ensure that YAML files can contain additional fields beyond what's defined in the schemas without causing validation errors.
Key changes:
- Added
extra="allow"to all Pydantic BaseModel configurations in schema files - Changed default values from hardcoded defaults to
Nonefor better roundtripping - Added validation error handling with new
PreCommitConfigYAMLConfigError - Updated model dumping calls to include
by_alias=Trueparameter
Reviewed Changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
tests/usethis/_integrations/pre_commit/test_pre_commit_io_.py |
Added test cases for extra config fields and invalid config validation |
src/usethis/_integrations/pre_commit/schema.py |
Added extra="allow" to all models and changed defaults to None for roundtripping |
src/usethis/_integrations/ci/bitbucket/schema_utils.py |
Updated model dump to include by_alias=True parameter |
src/usethis/_integrations/ci/bitbucket/schema.py |
Added extra="allow" to all models, changed defaults to None, and updated field configurations |
src/usethis/_integrations/ci/bitbucket/pipeweld.py |
Updated model dump JSON to include by_alias=True parameter |
pyproject.toml |
Updated datamodel-code-generator minimum version to 0.35.0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…thub.com/nathanjmcdougall/usethis-python into 151-how-to-deal-with-out-of-schema-logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.