Fix print-how-to-use for requirements.txt with none backend#1043
Merged
nathanjmcdougall merged 1 commit intomainfrom Oct 26, 2025
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
CodSpeed Performance ReportMerging #1043 will not alter performanceComparing Summary
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the "how to use" message for requirements.txt when using the none backend. The message now correctly says "write" instead of "re-write" when the file doesn't exist, and is suppressed entirely when the file already exists.
Key changes:
- Added a conditional check to only show the instruction message when
requirements.txtdoesn't exist - Updated the message text from "re-write" to "write" for clarity
- Updated test expectations to match the new behavior
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/usethis/_tool/impl/requirements_txt.py |
Added existence check and updated message text for none backend |
tests/usethis/_ui/interface/test_tool.py |
Removed assertion for instruction message when file exists |
tests/usethis/_tool/impl/test_requirements_txt.py |
Updated expected message text from "re-write" to "write" |
tests/usethis/_core/test_core_tool.py |
Removed assertion for instruction message when file exists |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nathanjmcdougall
deleted the
1024-misleading-message-run-usethis-tool-requirementstxt-to-re-write-requirementstxt
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.