Don't duplicate ignored rules matching glob#1042
Merged
nathanjmcdougall merged 1 commit intomainfrom Oct 26, 2025
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
CodSpeed Performance ReportMerging #1042 will not alter performanceComparing Summary
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where ignored rules for a specific glob pattern could be duplicated when ignore_rules_in_glob was called multiple times with the same rules. The fix checks for existing ignored rules before adding new ones.
Key Changes:
- Added deduplication logic to
ignore_rules_in_globmethod - Introduced new helper method
get_ignored_rules_in_globto retrieve currently ignored rules for a glob pattern - Added test case to verify duplicate rules are prevented
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/usethis/_tool/impl/ruff.py | Implements deduplication logic in ignore_rules_in_glob and adds new get_ignored_rules_in_glob helper method |
| tests/usethis/_core/test_core_tool.py | Adds regression test to verify duplicate INP rules are not added when use_import_linter is called multiple times |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nathanjmcdougall
deleted the
935-dont-add-a-duplicate-inp-rule-when-running-usethis-tool-import-linter-multiple-times
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.