Broaden exception handling in test_matches_schema_store tests#1009
Merged
nathanjmcdougall merged 1 commit intomainfrom Oct 13, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
CodSpeed Performance ReportMerging #1009 will not alter performanceComparing Summary
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR broadens exception handling in schema validation tests by replacing specific ConnectionError exceptions with the more general RequestException base class. This ensures that various HTTP-related errors (timeouts, DNS failures, etc.) are properly caught and handled during schema fetching operations.
- Updated exception handling from
ConnectionErrortoRequestExceptionin two test files - Maintains existing test skip behavior in CI environments when network issues occur
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/usethis/_integrations/pre_commit/test_pre_commit_schema.py | Broadened exception handling to catch all request-related exceptions |
| tests/usethis/_integrations/ci/bitbucket/test_bitbucket_schema.py | Broadened exception handling to catch all request-related exceptions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
nathanjmcdougall
deleted the
1008-make-test_matches_schema_store-tests-less-flaky
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.