deprecating fake user agent and installing from github#83
Conversation
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
|
Testing container is here urlstechie/urlchecker-action#100 and will link to issue that was opened on the action. |
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
| install_requires=INSTALL_REQUIRES, | ||
| install_requires=INSTALL_REQUIRES | ||
| + [ | ||
| "fake-useragent @ git+https://github.com/danger89/fake-useragent@master#egg=fake-useragent" |
There was a problem hiding this comment.
cant we just use pip instead of a link to gh here? or why are we using github instead of pip? is the dev version better than the released?
There was a problem hiding this comment.
Since the setup.py is controlling how pip installs the entire package, it needs to be in this format to work. Otherwise the installing user would have to run two separate commands, which is weird. You can try it out locally to see how it works!
SuperKogito
left a comment
SuperKogito
left a comment
There was a problem hiding this comment.
This looks good to me with the exception of the specified link. However, if you deem that needed then it is all good.
|
Awesome! I’m going to verify that this fixes the bug that was opened on the action (where I have another PR branch for a user to test) and then I’ll merge here, likely end of day Friday or whenever the person can test! |
2 participants
We are running into an issue (that I anticipated) that the original fake-useragent on pip is no longer working, so switching over to the alternative.
Signed-off-by: vsoch vsoch@users.noreply.github.com