adding support for serial and fixing bug that driver might not be defined#82
Merged
Conversation
…ined Signed-off-by: vsoch <vsochat@stanford.edu>
Signed-off-by: vsoch <vsochat@stanford.edu>
Collaborator
Author
|
okay I'm going back to bed - will be back later today! |
SuperKogito
approved these changes
Aug 4, 2022
SuperKogito
left a comment
SuperKogito
left a comment
Member
There was a problem hiding this comment.
Waw @vsoch, you fast <3 This looks good to me. Let's wait and see what do the testers say about it :)
|
Works for me as well :-) |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To test, you can do both:
and
Signed-off-by: vsoch vsochat@stanford.edu