fix(temurin): include specificversion in ReportConfig - #9850
Merged
Conversation
The source cache keys entries on ReportConfig. Omitting specificversion made two temurin sources differing only by that field hash identically, so the second source received the first one's value. Fixes #9821 Signed-off-by: Loïs Postula <lois@postu.la>
|
Tick the box to add this pull request to the merge queue (same as
|
olblak
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #9821
The source cache keys entries on
resource.ReportConfig()(pkg/core/cache/source.go:69), butTemurin.ReportConfig()omittedSpecificVersion.In the reported manifest the two
get_windows_x64_installer_urlsources differ only byspecificversion, resolved from the JDK21 vs JDK25 source. With that field dropped from the reported config both hashed to the same key, so the JDK25 source got a cache hit on the JDK21 installer URL. ThelatestJDKVersionsources were unaffected because they differ byfeatureversion, which was already reported.ReportConfigpredates the source cache. It was added in #4898 for report export, where the omission was harmless.SpecificVersionis neither sensitive nor context-specific, so it belongs in the reported config.Test
TestReportConfigasserts the reported config round-trips the full spec, so a future field addition that forgetsReportConfigfails the test.Additional Information
Checklist
Tradeoff
None. The change is additive and the field carries no secrets.
Potential improvement
This is not isolated to temurin. 11 other plugins omit spec fields that change what
Source()returns, so the same silent cache collision applies to them. Audit and open questions in #9849.