fix: flux OCIRepository autodiscovery with digest - #9744
Merged
Conversation
Update OCIRepository autodiscovery manifest templates to put the digest (without leading "@") into the separate `$.spec.ref.digest` key.
Member
|
Thanks for the pullrequest, can you confirm that you tested manually on your project? |
olblak
approved these changes
Jul 30, 2026
|
Tick the box to add this pull request to the merge queue (same as
|
Contributor
Author
Yes, the changes seem to fix the issue on my end. |
olblak
approved these changes
Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update OCIRepository autodiscovery manifest templates to put the digest (without leading "@") into the separate
$.spec.ref.digestkey, instead of bothtag@digestin the$.spec.ref.tagkey.Fixes #9743
Test
To test this pull request, you can run the following commands:
Additional Information
Checklist
Tradeoff
Potential improvement
The autodiscovery manifests will fail if the target OCIRepository does not already have the
digestkey. I looked into adding a "CreateMissingKey" field in the yaml target spec, but the scope of work became much bigger than this fix. Better as a separate change I think.