fix(version): use original version string instead of re-formatted date for lookup - #9705
Open
AruneshDwivedi wants to merge 2 commits into
Open
fix(version): use original version string instead of re-formatted date for lookup#9705AruneshDwivedi wants to merge 2 commits into
AruneshDwivedi wants to merge 2 commits into
Conversation
…e for lookup Search formats the parsed time back to a string using the layout, then uses that as a map key into rawversions. The map keys are the original version strings which may not round-trip through Parse+Format (e.g. layout truncation loses microsecond precision or original formatting). Track the original version alongside each parsed time so the correct key is used for the map lookup. Signed-off-by: Arunesh Dwivedi <arunesh.devops@gmail.com>
Member
|
Thanks for the contribution, could I ask you to follow the pulln request template and explain how to reproduce this issue with a release Updatecli manifest? It's meant to help me review the change without spending too much time on each pr because now I quite often receive code contribution generated by AI that do not always make sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Search formats parsed time values back to strings using the layout, then uses those formatted strings as map keys into rawversions. The map is keyed by the original version strings, so after formatting loses precision or changes format, the lookup silently returns an empty string.
Track the original version string alongside each parsed time during Init, so Search can look up the correct key in rawversions.