Fix CI races in workspace saves, login, and storage failover - #65
Open
ernestrc wants to merge 3 commits into
Open
Fix CI races in workspace saves, login, and storage failover#65ernestrc wants to merge 3 commits into
ernestrc wants to merge 3 commits into
Conversation
Defer watcher conflict checks until file operations settle, and keep test UI callbacks queued until IDE startup finishes. Reconnect idle storage followers so a lost goodbye cannot prevent leader election. Pin the Blue callback-flush fix to prevent OAuth server shutdown from truncating the response. Add deterministic regressions for the failures observed in PR #57. Signed-off-by: ernestrc <ernest@unstable.build>
Reopening the saved path can observe a concurrent external write. Verify changed timestamps against the saved bytes before adopting them, so watcher rechecks and later saves do not mistake that external edit for our own save. Track the swap digest separately from mutable editor content and avoid an extra read when rename preserves the saved timestamp. Signed-off-by: ernestrc <ernest@unstable.build>
A fast expander could hold the descriptor hand-off mutex in StartCommand before Init reached SetDefaultAttributes, deadlocking construction against a parked executor. Finish synchronous initialization before launching the spawn worker while retaining Close serialization. Signed-off-by: ernestrc <ernest@unstable.build>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes four underlying CI failures reported on #57 (without changing that fork PR):
Validation
Dependency
Blue PR unstablebuild/blue#3 is the companion upstream fix and its complete CI matrix passes. Rune pins its immutable commit as a Go pseudo-version; no local replace or release publication is required.