Skip to content

Display warning-text in File Manager dialogbox in orange#2518

Merged
limetech merged 1 commit intounraid:masterfrom
mgutt:fix-dialog-warning-color
Jan 13, 2026
Merged

Display warning-text in File Manager dialogbox in orange#2518
limetech merged 1 commit intounraid:masterfrom
mgutt:fix-dialog-warning-color

Conversation

@mgutt
Copy link
Contributor

@mgutt mgutt commented Jan 13, 2026 •
edited by coderabbitai bot
Loading

As requested in this comment of @SimonFair

image

Summary by CodeRabbit

Style

  • Updated visual styling for warning elements displayed in File Manager dialogs
  • Refined CSS class assignments and color properties affecting warning presentation

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 13, 2026 •
edited
Loading

Walkthrough

A warning element's styling is updated in the File Manager. The HTML element receives an additional "warning" UI class, and a color property is removed from the corresponding CSS rule. The functional behavior remains unchanged.

Changes

Cohort / File(s) Change Summary
Warning Element Styling
emhttp/plugins/dynamix/Browse.page, emhttp/plugins/dynamix/styles/default-dynamix.css		 Added "warning" UI class to warning div; removed color: var(--alt-text-color); from .ui-dialog-buttonpane .dfm-warning CSS rule

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A warning wears a brand new class,
While colors fade like morning grass,
The style shifts in subtle grace,
No logic breaks—just UI's face! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Display warning-text in File Manager dialogbox in orange' accurately describes the main change: applying CSS styling to make warning text appear in orange in the File Manager dialog. It directly relates to the changeset modifications in both files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📜 Recent review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 94f8272 and 372a90c.

📒 Files selected for processing (2)
  • emhttp/plugins/dynamix/Browse.page
  • emhttp/plugins/dynamix/styles/default-dynamix.css
💤 Files with no reviewable changes (1)
  • emhttp/plugins/dynamix/styles/default-dynamix.css
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-05T19:26:36.587Z 
Learnt from: zackspear
Repo: unraid/webgui PR: 2354
File: emhttp/plugins/dynamix/ShareEdit.page:0-0
Timestamp: 2025-09-05T19:26:36.587Z
Learning: In emhttp/plugins/dynamix/ShareEdit.page, the clone-settings div was moved outside the form element and both are wrapped in a div.relative container to prevent event bubbling issues while maintaining proper positioning.

Applied to files:

  • emhttp/plugins/dynamix/Browse.page
🔇 Additional comments (1)
emhttp/plugins/dynamix/Browse.page (1)

99-103: LGTM! Clean approach to apply warning styling.

Adding the warning class alongside dfm-warning is the right approach—it leverages the existing framework styling for orange warning text while preserving any dialog-specific positioning from dfm-warning. This aligns with the PR objective and the corresponding CSS change that removed the color override.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Jan 13, 2026

🔧 PR Test Plugin Available

A test plugin has been generated for this PR that includes the modified files.

Version: 2026.01.13.1645
Build: View Workflow Run

📥 Installation Instructions:

Install via Unraid Web UI:

  1. Go to Plugins → Install Plugin
  2. Copy and paste this URL:
https://preview.dl.unraid.net/pr-plugins/pr-2518/webgui-pr-2518.plg
  1. Click Install

Alternative: Direct Download

⚠️ Important Notes:

  • Testing only: This plugin is for testing PR changes
  • Backup included: Original files are automatically backed up
  • Easy removal: Files are restored when plugin is removed
  • Conflicts: Remove this plugin before installing production updates

📝 Modified Files:

Click to expand file list 
emhttp/plugins/dynamix/Browse.page
emhttp/plugins/dynamix/styles/default-dynamix.css

🔄 To Remove:

Navigate to Plugins → Installed Plugins and remove webgui-pr-2518, or run:

plugin remove webgui-pr-2518

🤖 This comment is automatically generated and will be updated with each new push to this PR.

SimonFair
SimonFair reviewed Jan 13, 2026
View reviewed changes
Copy link
Contributor

@SimonFair SimonFair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, Thanks for the quick turn around.

@SimonFair SimonFair added the 7.3 label Jan 13, 2026
@limetech limetech merged commit 306da0a into unraid:master Jan 13, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SimonFair SimonFair SimonFair left review comments

Assignees

No one assigned

Labels

7.3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mgutt @SimonFair @limetech