Skip to content

fix: disable rc.avahidnsconfd by default#2469

Merged
limetech merged 2 commits intomasterfrom
fix-disable-avahidnsconfd
Dec 3, 2025
Merged

fix: disable rc.avahidnsconfd by default#2469
limetech merged 2 commits intomasterfrom
fix-disable-avahidnsconfd

Conversation

@ljm42
Copy link
Member

@ljm42 ljm42 commented Dec 3, 2025 •
edited by coderabbitai bot
Loading

rc.avahidaemon remains active

Summary by CodeRabbit

  • Chores
    • Disabled automatic startup of the avahidnsconfd service by default; it will no longer start during system boot. If needed, start the service manually.

✏️ Tip: You can customize this high-level summary in your review settings.

@ljm42
fix: disable rc.avahidnsconfd by default
8f2e6ed 
rc.avahidaemon remains active
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 3, 2025 •
edited
Loading

Walkthrough

The avahidnsconfd startup invocation in etc/rc.d/rc.M has been commented out and annotated as disabled by default; the daemon will no longer be started automatically during system boot and must be invoked manually when needed.

Changes

Cohort / File(s) Summary
Service Startup Modification
etc/rc.d/rc.M		 Commented-out avahidnsconfd startup line and added a preceding comment explaining the service is disabled by default.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Single-file, minimal change (comment + note).
  • Review focus: confirm the correct line was commented and the comment wording is accurate.

Poem

🐇 I tuck the daemon in where silence grows,
A whispered line of code that softly dozes,
No morning call, no boot-time chime,
Wake me gently when you choose the time,
— a rabbit's hop through sleepy startup roses.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: disable rc.avahidnsconfd by default' directly and clearly describes the main change: disabling rc.avahidnsconfd by default, which matches the actual modification in rc.M where the startup line is commented out and disabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-disable-avahidnsconfd
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8f2e6ed and 408fc97.

📒 Files selected for processing (1)
  • etc/rc.d/rc.M (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • etc/rc.d/rc.M
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Analyze (javascript-typescript)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai bot reviewed Dec 3, 2025
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fa9a481 and 8f2e6ed.

📒 Files selected for processing (1)
  • etc/rc.d/rc.M (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings 
Learnt from: ljm42
Repo: unraid/webgui PR: 2414
File: etc/rc.d/rc.nginx:374-376
Timestamp: 2025-10-03T02:57:29.994Z
Learning: Repo unraid/webgui: In etc/rc.d/rc.nginx, maintainers prefer not to add explicit mv-failure checks or EXIT trap clearing around atomic writes in build_servers(), build_locations(), and build_ini(); treat mv failures (e.g., disk full/permissions) as non-recoverable and keep the implementation simple.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Analyze (javascript-typescript)

@ljm42 @coderabbitai
fix typo
408fc97 
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@limetech limetech merged commit ca84872 into master Dec 3, 2025
4 checks passed
@limetech limetech deleted the fix-disable-avahidnsconfd branch December 3, 2025 22:55
@github-actions
Copy link

github-actions bot commented Dec 3, 2025

🧹 PR Test Plugin Cleaned Up

The test plugin and associated files for this PR have been removed from the preview environment.

🤖 This comment is automatically generated when a PR is closed.

ljm42 added a commit that referenced this pull request Dec 12, 2025
@ljm42
backport: fix: disable rc.avahidnsconfd by default
0c06496 
backport from #2469
@ljm42 ljm42 mentioned this pull request Dec 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ljm42 @limetech