api/src/unraid-api/cli/restart.command.ts (3)

22-22: Make options optional to match nest-commander’s run signature

The second parameter is optional per the docs; marking it optional avoids potential runtime surprises if no options object is provided.

Apply this diff:

-    async run(_: string[], options: RestartCommandOptions): Promise<void> {
+    async run(_: string[], options?: RestartCommandOptions): Promise<void> {

---

24-25: Optional: include the log level in the status message

Helps with operability and debugging.

Apply this diff:

-            this.logger.info('Restarting the Unraid API...');
+            this.logger.info(`Restarting the Unraid API (log level: ${options?.logLevel ?? 'info'})...`);

---

50-57: Bind the option name explicitly and enforce valid values via Commander choices

• Add name: 'logLevel' so the parsed option is exposed as options.logLevel.
• Use choices: [...levels] to let Commander validate inputs and remove manual checks.

Apply this diff in api/src/unraid-api/cli/restart.command.ts (around lines 50–57):

     @Option({
-        flags: `--log-level <${levels.join('|')}>`,
+        flags: '-l, --log-level <level>',
         description: 'log level to use',
         defaultValue: 'info',
+        name: 'logLevel',
+        choices: [...levels],
     })
-    parseLogLevel(val: string): LogLevel {
-        return levels.includes(val as LogLevel) ? (val as LogLevel) : 'info';
-    }
+    parseLogLevel(val: string): LogLevel {
+        // Commander guarantees val ∈ levels
+        return val as LogLevel;
+    }

To verify locally, build and test the CLI:

#!/bin/bash
set -e

# 1) Build project
npm run build

# 2) Valid log-level should succeed
node dist/main.js restart --log-level debug --help >/dev/null

# 3) Invalid log-level should exit non-zero
if node dist/main.js restart --log-level verbose; then
  echo "❌ Invalid value was accepted"
  exit 1
else
  echo "✅ Invalid value correctly rejected"
fi

(Or, without building, run via ts-node:
npx ts-node api/src/unraid-api/cli/restart.command.ts restart --log-level debug --help)

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

api/src/unraid-api/cli/restart.command.ts (1)

9-11: Fix option key: use logLevel?: LogLevel instead of 'log-level'?: string.

Commander maps --log-level to logLevel. Reading 'log-level' will be undefined at runtime and loses type safety.

Apply this diff:

 interface RestartCommandOptions {
-    'log-level'?: string;
+    logLevel?: LogLevel;
 }

api/src/unraid-api/cli/restart.command.ts (1)

50-57: Option parsing is solid; add a short alias and tighten types (optional).

• Add -l alias for ergonomics.
• Current parser is fine; keeping both defaultValue: 'info' and the fallback in parseLogLevel is defensive. No change required, but you could rely on just one source of default to reduce duplication.

Apply this diff for the alias:

     @Option({
-        flags: `--log-level <${levels.join('|')}>`,
+        flags: `-l, --log-level <${levels.join('|')}>`,
         description: 'log level to use',
         defaultValue: 'info',
     })
     parseLogLevel(val: string): LogLevel {
         return levels.includes(val as LogLevel) ? (val as LogLevel) : 'info';
     }

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

api/src/unraid-api/cli/restart.command.ts (1)

27-27: Great: extendEnv: true prevents clobbering the inherited env.

This addresses earlier feedback about preserving PATH and other vars.

api/src/unraid-api/cli/restart.command.ts (1)

25-25: Precedence is right, but casing may vary across sources.

You’re mixing lowercase CLI values with uppercase LOG_LEVEL. Downstream normalizes via toUpperCase() (environment.ts), so behavior is correct. Optional: normalize here for clarity.

Possible tweak:

-const env = { LOG_LEVEL: options.logLevel ?? LOG_LEVEL };
+const env = { LOG_LEVEL: (options.logLevel ?? LOG_LEVEL) as string };

(or normalize explicitly to lower/upper consistently)

api/src/unraid-api/cli/start.command.ts (2)

4-4: Avoid type coupling between commands; move LogLevelOptions to a shared module.

Even as a type-only import, referencing another command is fragile. Consider exporting LogLevelOptions from @app/core/log.js (or @app/unraid-api/cli/types.js) and import from there.

Apply (example):

-import type { LogLevelOptions } from '@app/unraid-api/cli/restart.command.js';
+import type { LogLevelOptions } from '@app/core/log.js';

---

37-39: Use consistent log level for stdout messages.

Restart uses info; Start uses log. Prefer consistency.

-        if (stdout) {
-            this.logger.log(stdout.toString());
-        }
+        if (stdout) {
+            this.logger.info(stdout.toString());
+        }

api/docs/public/cli.md (2)

27-31: Clarify precedence with env vs flag.

Add a note that the flag overrides LOG_LEVEL when provided; otherwise the service uses LOG_LEVEL (or defaults per environment).

Proposed patch:

-Alternative: You can also set the log level using the `LOG_LEVEL` environment variable:
+Note: If `--log-level` is provided it takes precedence. Otherwise the service uses the `LOG_LEVEL` environment variable (falling back to its built-in default).
+
+You can set the log level using the `LOG_LEVEL` environment variable:

---

58-59: Mirror the precedence note in Restart section.

Maintain consistency with Start docs.

-Alternative: You can also set the log level using the `LOG_LEVEL` environment variable:
+Note: If `--log-level` is provided it takes precedence. Otherwise the service uses the `LOG_LEVEL` environment variable (falling back to its built-in default).
+
+You can set the log level using the `LOG_LEVEL` environment variable:

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

api/src/unraid-api/cli/restart.command.ts (1)

51-55: Remove defaultValue; it prevents true env fallback and may case-mismatch

With a default here, options.logLevel is always defined, so we never fall back to the existing environment. Also, LOG_LEVEL from environment is uppercase (e.g., INFO) while CLI levels are lowercase; the mismatch can lead to silent coercion later.

     @Option({
         flags: `--log-level <${levels.join('|')}>`,
         description: 'log level to use',
-        defaultValue: LOG_LEVEL,
     })

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

api/src/unraid-api/cli/restart.command.ts (1)

59-66: Remove the default to avoid overriding existing LOG_LEVEL; fail fast remains intact.

With a default, the option is always defined and you always inject a value, which prevents true fallback to an already-configured PM2/env value. This reiterates a prior comment, but it still applies with LOG_LEVEL.toLowerCase().

 @Option({
   flags: `--log-level <${levels.join('|')}>`,
   description: 'log level to use',
-  defaultValue: LOG_LEVEL.toLowerCase(),
 })
 parseLogLevel(val: string): LogLevel {
   return parseLogLevelOption(val);
 }

If you apply this, also remove the now-unused LOG_LEVEL import.

api/src/unraid-api/cli/restart.command.ts (3)

3-5: ESM import specifiers look good; consider dropping LOG_LEVEL import if not used.

If you remove the default from the option (see comment below), LOG_LEVEL import becomes unnecessary here.

---

13-19: Trim the value before normalizing.

Handles accidental whitespace in flags or env, e.g., --log-level " debug ".

Apply:

-export function parseLogLevelOption(val: string, allowedLevels: string[] = [...levels]): LogLevel {
-    const normalized = val.toLowerCase() as LogLevel;
+export function parseLogLevelOption(val: string, allowedLevels: string[] = [...levels]): LogLevel {
+    const normalized = val.trim().toLowerCase() as LogLevel;
     if (allowedLevels.includes(normalized)) {
         return normalized;
     }
     throw new Error(`Invalid --log-level "${val}". Allowed: ${allowedLevels.join(', ')}`);
 }

---

30-36: Optional: log the effective level for observability.

Helps confirm which level PM2 received during troubleshooting.

-      const { stderr, stdout } = await this.pm2.run(
+      if (level) this.logger.info(`Using log level: ${level}`);
+      const { stderr, stdout } = await this.pm2.run(

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.