Skip to content

fix: .env.production from allowing console logs on build#1273

Merged
elibosley merged 1 commit intomainfrom
fix/web-env-prod-no-console-logs
Mar 26, 2025
Merged

fix: .env.production from allowing console logs on build#1273
elibosley merged 1 commit intomainfrom
fix/web-env-prod-no-console-logs

Conversation

@zackspear
Copy link
Contributor

@zackspear zackspear commented Mar 25, 2025 •
edited by coderabbitai bot
Loading

VITE_ALLOW_CONSOLE_LOGS should not be present in .env.production. We don't want basic debugs logs in prod.

Found this because the latest OS release 7.1.0-beta.1.6 which included the latest web components had debug logs included.

Summary by CodeRabbit

  • Chores
    • Disabled non-essential console logging in the production environment for a cleaner runtime experience.

@zackspear zackspear requested review from pujitm and removed request for elibosley and mdatelle March 25, 2025 22:50
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 25, 2025 •
edited
Loading

Walkthrough

This pull request removes a specific comment and an environment variable from the production configuration file. The changes disable console log output in the production environment by deleting the log-related comment and the VITE_ALLOW_CONSOLE_LOGS declaration.

Changes

File Change Summary
web/.env.production Removed comment # Keep console logs until components are stabilized and the environment variable declaration VITE_ALLOW_CONSOLE_LOGS=true

Possibly related PRs

Suggested reviewers

  • pujitm
  • elibosley
  • mdatelle

Poem

In the code realm a silence now spreads,
A comment and variable quietly put to bed.
Console logs shelter from the production night,
Leaving a cleaner space, calm and light.
Cheers to the change that sets our code right!
🚀✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 6636f65 and 015f562.

📒 Files selected for processing (1)
  • web/.env.production (0 hunks)
💤 Files with no reviewable changes (1)
  • web/.env.production
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: Build Web App
  • GitHub Check: Build API
  • GitHub Check: Test API
  • GitHub Check: Cloudflare Pages
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@zackspear zackspear requested a review from elibosley March 25, 2025 22:51
@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2025

This plugin has been deployed to Cloudflare R2 and is available for testing.
Download it at this URL:

https://preview.dl.unraid.net/unraid-api/tag/PR1273/dynamix.unraid.net.plg

@elibosley elibosley merged commit 32acc2d into main Mar 26, 2025
8 checks passed
@elibosley elibosley deleted the fix/web-env-prod-no-console-logs branch March 26, 2025 13:16
@github-actions github-actions bot mentioned this pull request Mar 25, 2025
Merged
mdatelle pushed a commit that referenced this pull request Mar 26, 2025
@zackspear
fix: .env.production from allowing console logs on build (#1273)
1b5f53a 
`VITE_ALLOW_CONSOLE_LOGS` should not be present in `.env.production`. We
don't want basic debugs logs in prod.

Found this because the latest OS release `7.1.0-beta.1.6` which included
the latest web components had debug logs included.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Disabled non-essential console logging in the production environment
for a cleaner runtime experience.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
elibosley pushed a commit that referenced this pull request Mar 27, 2025
@github-actions
chore(main): release 4.4.1 (#1270)
4295ca1 
🤖 I have created a release *beep* *boop*
---


## [4.4.1](v4.4.0...v4.4.1)
(2025-03-26)


### Bug Fixes

* .env.production from allowing console logs on build
([#1273](#1273))
([32acc2d](32acc2d))
* patch version override logic incorrect
([#1275](#1275))
([6a59756](6a59756))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This was referenced Mar 27, 2025
Closed
Merged
Merged
This was referenced Apr 3, 2025
Merged
Merged
Merged
Merged
@coderabbitai coderabbitai bot mentioned this pull request Jul 22, 2025
Closed
@github-actions github-actions bot mentioned this pull request Oct 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pujitm pujitm Awaiting requested review from pujitm

@elibosley elibosley Awaiting requested review from elibosley

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zackspear @elibosley