Skip to content

chore: ensure files are uploaded with proper content encoding #1254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
elibosley merged 3 commits into from
Mar 21, 2025
Merged

chore: ensure files are uploaded with proper content encoding #1254

elibosley merged 3 commits into from
Mar 21, 2025

Conversation

@elibosley
Copy link
Member

@elibosley elibosley commented Mar 19, 2025 •
edited by coderabbitai bot
Loading

This should fix the recent CA issues

Summary by CodeRabbit

  • Chores
    • Enhanced the asset upload process to ensure all content is processed with optimized performance settings and made publicly accessible.
    • Strengthened the deployment framework with refined file handling parameters for more reliable delivery.
    • These improvements collectively result in a smoother, more consistent experience for users when accessing content.

@elibosley elibosley requested a review from pujitm March 19, 2025 16:17
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 19, 2025 •
edited
Loading

Warning

Rate limit exceeded

@elibosley has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 10 minutes and 11 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between ef44ef5 and ac812a5.

📒 Files selected for processing (2)
  • .github/workflows/main.yml (1 hunks)
  • .github/workflows/release-production.yml (2 hunks)

Walkthrough

The pull request updates AWS S3 sync commands in two GitHub workflow files. Both .github/workflows/main.yml and .github/workflows/release-production.yml now include the additional parameters --no-guess-mime-type and --acl public-read. The comments preceding the commands have been revised to clarify these updates. There are no alterations to exported or public entity declarations.

Changes

File(s) Change Summary
.github/workflows/main.yml
.github/workflows/release-production.yml		 Updated AWS S3 sync commands to include --no-guess-mime-type and --acl public-read for Cloudflare and Digital Ocean Spaces uploads. Updated command comments.

Possibly related PRs

  • unraid/webgui-patches#279: The changes in this PR involve similar updates to AWS S3 sync commands with added parameters for content handling and access control.
  • unraid/auth#517: Modifications in this PR also focus on AWS S3 sync commands with similar parameters for content handling and access control.
  • feat: auto-docusaurus-prs #1127: This PR introduces analogous changes to AWS S3 sync commands, specifically adding parameters for content handling and access control.

Poem

In the realm of workflows, commands align,
Sync flags added, making uploads shine.
With types guessed no more, and access set to read,
Files take flight, fulfilling every need.
A small change, a smoother code—success indeed!

🎉🚀

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 19, 2025

This plugin has been deployed to Cloudflare R2 and is available for testing.
Download it at this URL:

https://preview.dl.unraid.net/unraid-api/tag/PR1254/dynamix.unraid.net.plg

@elibosley elibosley requested a review from zackspear March 20, 2025 18:52
pujitm
pujitm approved these changes Mar 21, 2025
View reviewed changes
Copy link
Member

@pujitm pujitm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a sanity check on whether a content-type of text/plain or text/xml/application/xml is prefereable

@elibosley
Copy link
Member Author

elibosley commented Mar 21, 2025

just a sanity check on whether a content-type of text/plain or text/xml/application/xml is prefereable

Unfortunately we can't do that because some of the content is these tgz files.

@elibosley elibosley merged commit 2e85c74 into main Mar 21, 2025
8 checks passed
@elibosley elibosley deleted the fix/aws-content-encoding branch March 21, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pujitm pujitm pujitm approved these changes

@zackspear zackspear Awaiting requested review from zackspear

+1 more reviewer

@mdatelle mdatelle mdatelle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@elibosley @mdatelle @pujitm