Closed
fix: make vite a dynamic import and declare it as optional peer dependency#259
Conversation
|
|
5 tasks
Copilot
AI
changed the title
[WIP] Fix unplugin-solid dependency issue with vite
fix: make vite a dynamic import and declare it as optional peer dependency
Jul 13, 2026
so1ve
marked this pull request as ready for review
July 13, 2026 19:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unplugin-solidhad a static top-levelimport { version } from "vite"that caused a hard runtime failure in strict dependency environments (Yarn PnP) when consumers weren't using Vite — the module would fail to load even for Rollup/esbuild/webpack users.Changes
src/core/index.ts: Replace staticimport { version } from "vite"with a dynamicawait import("vite")scoped to the Vite-specificconfighook where it's actually needed, with a clear error message if the import failspackage.json: Declarevite >=4as an optional peer dependency viapeerDependenciesMeta