feat(compiler): add css compiler#90
Conversation
fix: add svg xmlns if missing on source
fix: use 1.2 instead 1 as default scale
fix: convert always double quotes to single ones
|
Maybe we need to override also options passed to use the |
|
We also need to check if we need to remove some svg attrs when generating before calling the CSS compiler. |
|
EDIT: there is no need to change it. |
|
Seems we need to use We also need to prevent adding twice the svg |
|
I don't know if we need the |
|
This looks comprehensive. Nice to see examples in multiple frameworks and documentation. |
# Conflicts: # src/core/svgId.ts # src/types.ts
# Conflicts: # src/types.ts
|
Thanks for the awesome work! I have thought about this for a while and I think this is a very interesting solution - but maybe this is not the best place for it (you will need to import every icon to use it, which is not optimal). I have been working on a better way to do it for a while and will be out soon. stay turned :) |
|
Here: https://twitter.com/antfu7/status/1452802545118711812 I am closing this for now. Another post about the implementation details of the Pure CSS Icons solution will also come soon. Thanks for the inspiration and hard work on this! @husayt @userquin 🙌 |



closes #88