Run & review this pull request in StackBlitz Codeflow.

Run the build command, ember.d.ts types should be added to the subpackage exports at package json file.

Try to reduce both ember examples to minimal required code to test the icons 🙏 (update root .gitignore to exclude ember stuff at examples).

I can do that -- @rtablada can you add me as a collaborator on your fork? <3

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@​ember/​app-tsconfig@​1.0.3
	@​embroider/​webpack@​4.1.1
	vue-tsc@​3.1.1
	@​embroider/​compat@​3.9.1
	@​embroider/​core@​3.5.7
	@​embroider/​core@​4.2.4
	@​babel/​plugin-transform-runtime@​7.15.0 ⏵ 7.28.3			+1
	@​babel/​runtime@​7.15.4 ⏵ 7.28.4	+1	+4	+1
	@​ember/​optional-features@​2.2.0
	unplugin-vue-components@​28.8.0
	nuxt@​4.1.3
	@​embroider/​macros@​1.19.1
	@​embroider/​router@​3.0.4
	@​embroider/​vite@​1.3.2

View full report

hm, any way I can see details on why socket.io is saying my deps are bad? 😢

I thiiiink this is ready for review?
Happy to do whatever else is needed though

Did you run the build command from root? ./types/ember subpackage export should be added to the package.json by tsdown.

hm, any way I can see details on why socket.io is saying my deps are bad? 😢

I'm getting also forbidden message 🤔

Check https://socket.dev/?utm_medium=gh, you have some hints at the end of the page

Open in StackBlitz

npm i https://pkg.pr.new/unplugin-icons@419

commit: 2a2da4d

We still need the ember types at subpackage exports, just run pnpm build from root folder and push the changes added by tsdown build.

Will do a review tmr from laptop

can you run pnpm lint from root? Maybe we need to change also eslint config file (rules)

there is a failing lint at the moment, because one of the lint rules has assumed all .map functions are Array.prototype.map 🙈

I pushed a little ignore with details about why in my most recent commit

Looks like ember doing weird things without test/index.html entry point (ember plugin checking some entries in the rollup configuration entry), check the error below (dev server working, only tested with Vite):

dev server error

check the error below (dev server working, only tested with Vite):

yea, I need to fix that 🙈 it's very easy to check if that file exists before adding the entrypoint, I just keep forgetting 🫠

we should add a link here

I can do that! <3

thanks for the reminder! embroider-build/embroider#2584 <3

@NullVoxPopuli can you find me at discord at antfu server unplugin-icons channel? I have a few questions about Ember and IDE support...

https://discord.gg/DMn6tWHV

The warning on vite boot has been fixed upstream

The warning on vite boot has been fixed upstream

can you update the playgrounds?

no need, the ^ range on the dependency will cover it