fix(nuxt): inject types for nuxt 4 too (+ add nuxt 4 example)#406
Merged
antfu merged 1 commit intounplugin:mainfrom Jul 29, 2025
Merged
fix(nuxt): inject types for nuxt 4 too (+ add nuxt 4 example)#406antfu merged 1 commit intounplugin:mainfrom
antfu merged 1 commit intounplugin:mainfrom
Conversation
|
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
antfu
reviewed
Jul 24, 2025
| .idea | ||
| .svelte-kit/ | ||
| examples/nuxt3/pnpm-lock.yaml | ||
| examples/nuxt4/pnpm-lock.yaml |
Member
There was a problem hiding this comment.
As Nuxt3 and Nuxt4 is basically the same, I don't think we need to keep two versions in the examples. We could just rename the folder and bump the deps
Contributor
Author
There was a problem hiding this comment.
deleted the nuxt 3 folder
415a73b to
bb34fc3
Compare
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
bb34fc3 to
c35099e
Compare
antfu
approved these changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
make sure to inject types into projects that use the newly released nuxt 4.
Linked Issues
didn't bother to open one. you can revert the change and run
pnpm run typecheckto see the (vue-)tsc errorAdditional context
not sure if there is a better way to make this check, maybe parse it as it and assert > 2 or something? nuxt 5 isnt thaaaat far away (but also easy enough to fix).
also not sure if a nuxt 4 example was worth but, but I figured since the dir structure is different it might be a good idea.
for anyone running into this too: you can manually add the types to your nuxt config for now: