Skip to content

Conversation

@ChrisSmartGP
Copy link

First up i'd just like to say thanks so much for all the work that has gone into this library :)

I've encountered an issue where setting the time does not work when 'pm' is set and the user tries to enter the values 10, 11 or 12 in the hour input.

When in a locale that uses 12 hour time format:

  • the updateHour method should have a max accepted value of 12
  • the internally represented time should convert back to 12 hour format before using the updateHour method. Not doing so will cause the method to return early
  • I added a method to determine the hourCycle from the locale but I think maybe this should just use the props.hourCycle. However props.hourCycle is undefined unless it is explicitly passed

@zernonia
Copy link
Member

zernonia commented Nov 4, 2025

Yo @ChrisSmartGP ! Appreciate the PR, could you create a ticket and explain the issue with reproduction please? 🙏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants