fix (TimeField): call to updateHour to handle 12 hour time #2254
+30
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First up i'd just like to say thanks so much for all the work that has gone into this library :)
I've encountered an issue where setting the time does not work when 'pm' is set and the user tries to enter the values 10, 11 or 12 in the hour input.
When in a locale that uses 12 hour time format:
updateHourmethod should have a max accepted value of 12updateHourmethod. Not doing so will cause the method to return early