fix(HoverCard): reduce padding GraceArea #2217
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @Yves852 . Setting to 1 might cause some flickering issue, or unintended 'exit'. Will check on the issue soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2203
The function
getPaddedExitPointssets by default 5px of padding around the trigger's "exit points". This fix add the parameter to reduce the value to 1px. This change affectsHoverCardandTooltipcomponents.This may not fix completely the issue as the trigger area still have a padding that can overlap surrounding items but make it much less impacting.
By trying to set to 0px the grace area is cut into 2 pieces and moving the cursor from the trigger to the popped content will close it when the cursor is in-between and reopen it by meeting the second part.