Skip to content

Conversation

@NoelDeMartin
Copy link
Contributor

@NoelDeMartin NoelDeMartin commented Sep 12, 2025

I have documented this issue in #2160, this PR contains a proposal to fix it.

My solution is, basically, to always render the options in the Fragment; regardless of whether the options are showing in the popover or not. I'm not sure if rendering them twice can have any unintended consequences, but from the few tests I've done, it seems to work fine.

Edit: Well, it seems the tests are not passing so I'm converting this to a draft 😅. I'll look into it, but in the meantime if someone comes across this I'd appreciate some feedback on whether this is the right fix.

Edit 2: I've look into the tests, and honestly they are too coupled to internals of how the component works. I think a maintainer should look at this before I waste any time trying to understand that, so I'm moving this back to Ready for review until I get some feedback.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 12, 2025

Open in StackBlitz

npm i https://pkg.pr.new/reka-ui@2161

commit: 5c7410b

@NoelDeMartin NoelDeMartin marked this pull request as draft September 12, 2025 05:51
@NoelDeMartin NoelDeMartin marked this pull request as ready for review September 12, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant