fix(rspack): remove virtual plugin cleanup signal handlers#541
Merged
fix(rspack): remove virtual plugin cleanup signal handlers#541
Conversation
commit: |
sxzz
reviewed
Aug 27, 2025
src/rspack/utils.ts
Outdated
| this.counters.forEach((_, dir) => { | ||
| fs.rmSync(dir, { recursive: true, force: true }) | ||
| }) | ||
| process.once('exit', () => { |
Member
There was a problem hiding this comment.
Can we move this part to the constructor (or other lazy approach)? The static block will always be executed, regardless of whether rspack is used.
sxzz
reviewed
Aug 27, 2025
src/rspack/utils.ts
Outdated
| }) | ||
| }) | ||
| } | ||
| process.once('exit', FakeVirtualModulesPlugin.cleanupFn) |
Member
There was a problem hiding this comment.
Make sure this call will also be execute once.
Member
There was a problem hiding this comment.
if the flag is true, skip it. Instead of store a function.
src/rspack/utils.ts
Outdated
| export class FakeVirtualModulesPlugin { | ||
| name = 'FakeVirtualModulesPlugin' | ||
| static counters: Map<string, number> = new Map<string, number>() | ||
| static cleanupFn: (() => void) | null = null |
elbywan
force-pushed
the
fix/rspack-remove-signal-handlers
branch
from
c48bb90 to
00db236
Compare
elbywan
force-pushed
the
fix/rspack-remove-signal-handlers
branch
from
00db236 to
768f3e2
Compare
sxzz
approved these changes
Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing the cleanup handlers added in #538.