fix(rspack): gate virtual folder behind process pid#538
Merged
Conversation
ensures that the node_modules/.virtual folder deletion supports parallel runs
commit: |
ahabhgk
approved these changes
Aug 21, 2025
Member
|
This PR appears to have broken other apps TanStack/router#5023 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should resolve #537
process.pidsuffix to thenode_modules/.virtualfolder to stop sharing the folder between parallel rspack runs in separate processesstatic counterproperty is currently shared between all virtual paths/contexts. This PR turns it into a Map of counters indexed by path to ensure that every pending virtual folder (and not only the last one) will get deleted when the final running compiler shuts down.