fix(rspack): gate virtual folder behind process pid (#538)

elbywan · web-flow · commit 417a6bf85b2e · 2025-08-21T09:59:15.000+08:00
ensures that the node_modules/.virtual folder deletion supports parallel
runs
diff --git a/src/rspack/index.ts b/src/rspack/index.ts
@@ -32,7 +32,7 @@ export function getRspackPlugin<UserOptions = Record<string, never>>(
       apply(compiler) {
         // We need the prefix of virtual modules to be an absolute path so rspack lets us load them (even if it's made up)
         // In the loader we strip the made up prefix path again
-        const VIRTUAL_MODULE_PREFIX = resolve(compiler.options.context ?? process.cwd(), 'node_modules/.virtual')
+        const VIRTUAL_MODULE_PREFIX = resolve(compiler.options.context ?? process.cwd(), 'node_modules/.virtual', process.pid.toString())
 
         const meta: UnpluginContextMeta = {
           framework: 'rspack',
diff --git a/src/rspack/utils.ts b/src/rspack/utils.ts
@@ -17,19 +17,37 @@ export function isVirtualModuleId(encoded: string, plugin: ResolvedUnpluginOptio
 
 export class FakeVirtualModulesPlugin {
   name = 'FakeVirtualModulesPlugin'
-  static counter = 0
+  static counters: Map<string, number> = new Map<string, number>()
+
+  static {
+    ['SIGINT', 'SIGTERM', 'SIGQUIT', 'exit'].forEach((event) => {
+      process.once(event, () => {
+        this.counters.forEach((_, dir) => {
+          fs.rmSync(dir, { recursive: true, force: true })
+        })
+      })
+    })
+  }
+
   constructor(private plugin: ResolvedUnpluginOptions) {}
 
   apply(compiler: Compiler): void {
-    FakeVirtualModulesPlugin.counter++
     const dir = this.plugin.__virtualModulePrefix
     if (!fs.existsSync(dir)) {
       fs.mkdirSync(dir, { recursive: true })
     }
+    const counter = FakeVirtualModulesPlugin.counters.get(dir) ?? 0
+    FakeVirtualModulesPlugin.counters.set(dir, counter + 1)
+
     compiler.hooks.shutdown.tap(this.name, () => {
-      if (--FakeVirtualModulesPlugin.counter === 0) {
+      const counter = (FakeVirtualModulesPlugin.counters.get(dir) ?? 1) - 1
+      if (counter === 0) {
+        FakeVirtualModulesPlugin.counters.delete(dir)
         fs.rmSync(dir, { recursive: true, force: true })
       }
+      else {
+        FakeVirtualModulesPlugin.counters.set(dir, counter)
+      }
     })
   }
 
