feat: check MODE variable for isDevelopment and isProduction flags#114
Open
markflorkowski wants to merge 1 commit intounjs:mainfrom
Open
feat: check MODE variable for isDevelopment and isProduction flags#114markflorkowski wants to merge 1 commit intounjs:mainfrom
MODE variable for isDevelopment and isProduction flags#114markflorkowski wants to merge 1 commit intounjs:mainfrom
Conversation
| /** Detect if `NODE_ENV` environment variable is `dev` or `development` */ | ||
| export const isDevelopment = nodeENV === "dev" || nodeENV === "development"; | ||
| /** Detect if `NODE_ENV` environment variable is `dev` or `development`, or if `MODE` environment variable is `development` */ | ||
| export const isDevelopment = nodeENV === "dev" || nodeENV === "development" || env.MODE === "development"; |
There was a problem hiding this comment.
env.MODE === dev for consistency with nodeENv check?
Author
There was a problem hiding this comment.
According to what documentation I found, it doesn't appear that the value is set that way by anything. Can change though if it makes sense
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Currently n/a, can open an issue as well if you want me to.
❓ Type of change
📚 Description
Utilize the
MODEenvironment variable to check if we are in development or production in addition to other checks from before.The
MODEenvironment variable is used in Vite to differentiate running in development or production.📝 Checklist