Skip to content

Commit 6b9e06a

Browse files
committed
TypeTreeHelper - comment out problematic decref
1 parent 9a87a48 commit 6b9e06a

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

‎UnityPyBoost/TypeTreeHelper.cpp‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -527,7 +527,7 @@ inline PyObject *parse_class(PyObject *kwargs, TypeTreeNodeObject *node, TypeTre
527527
PyObject *extra_value = PyDict_GetItem(kwargs, child->_clean_name); // +1
528528
PyDict_SetItem(extras, child->_clean_name, extra_value); // +1
529529
PyDict_DelItem(kwargs, child->_clean_name); // -1
530-
Py_DECREF(extra_value); // -1
530+
//Py_DECREF(extra_value); // -1
531531
}
532532

533533
if (PyDict_Size(extras) == 0)
@@ -926,7 +926,7 @@ PyObject *read_typetree(PyObject *self, PyObject *args, PyObject *kwargs)
926926
{
927927
const char *kwlist[] = {"data", "node", "endian", "as_dict", "assetsfile", "classes", NULL};
928928
Py_buffer view;
929-
PyObject *node;
929+
PyObject *node = nullptr;
930930
int as_dict = 1;
931931
PyObject *value = nullptr;
932932
ReaderT reader;
@@ -1011,14 +1011,14 @@ PyObject *read_typetree(PyObject *self, PyObject *args, PyObject *kwargs)
10111011

10121012
if (reader.ptr != reader.end)
10131013
{
1014-
Py_DecRef(value);
1014+
Py_DECREF(value);
10151015
value = PyErr_Format(PyExc_ValueError, "Read %ld bytes, %ld remaining", reader.ptr - reader.start, reader.end - reader.ptr);
10161016
}
10171017

10181018
READ_TYPETREE_CLEANUP:
10191019
PyBuffer_Release(&view);
1020-
Py_DECREF(config.assetfile);
1021-
Py_DECREF(config.classes);
1020+
Py_XDECREF(config.assetfile);
1021+
Py_XDECREF(config.classes);
10221022
return value;
10231023
}
10241024

0 commit comments

Comments
 (0)