Skip to content

Commit 394bd82

Browse files
author
Antoine Lelièvre
committed
Fixed exposed parameter add bug
1 parent 44eee2b commit 394bd82

1 file changed

Lines changed: 13 additions & 5 deletions

File tree

Assets/com.alelievr.NodeGraphProcessor/Editor/Views/BaseGraphView.cs

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -722,18 +722,20 @@ protected virtual BaseEdgeConnectorListener CreateEdgeConnectorListener()
722722

723723
void InitializeGraphView()
724724
{
725-
graph.onExposedParameterListChanged += () =>
726-
{
727-
UpdateSerializedProperties();
728-
onExposedParameterListChanged?.Invoke();
729-
};
725+
graph.onExposedParameterListChanged += OnExposedParameterListChanged;
730726
graph.onExposedParameterModified += (s) => onExposedParameterModified?.Invoke(s);
731727
graph.onGraphChanges += GraphChangesCallback;
732728
viewTransform.position = graph.position;
733729
viewTransform.scale = graph.scale;
734730
nodeCreationRequest = (c) => SearchWindow.Open(new SearchWindowContext(c.screenMousePosition), createNodeMenu);
735731
}
736732

733+
void OnExposedParameterListChanged()
734+
{
735+
UpdateSerializedProperties();
736+
onExposedParameterListChanged?.Invoke();
737+
}
738+
737739
void InitializeNodeViews()
738740
{
739741
graph.nodes.RemoveAll(n => n == null);
@@ -1290,6 +1292,12 @@ public void Dispose()
12901292
Object.DestroyImmediate(nodeInspector);
12911293
NodeProvider.UnloadGraph(graph);
12921294
exposedParameterFactory.Dispose();
1295+
exposedParameterFactory = null;
1296+
Debug.Log("Dispose field factory!");
1297+
1298+
graph.onExposedParameterListChanged -= OnExposedParameterListChanged;
1299+
graph.onExposedParameterModified += (s) => onExposedParameterModified?.Invoke(s);
1300+
graph.onGraphChanges -= GraphChangesCallback;
12931301
}
12941302

12951303
#endregion

0 commit comments

Comments
 (0)