Bump bleach from 3.0.2 to 3.1.4 - #9
Merged
Merged
Conversation
Bumps [bleach](https://github.com/mozilla/bleach) from 3.0.2 to 3.1.4. - [Release notes](https://github.com/mozilla/bleach/releases) - [Changelog](https://github.com/mozilla/bleach/blob/master/CHANGES) - [Commits](mozilla/bleach@v3.0.2...v3.1.4) Signed-off-by: dependabot[bot] <support@github.com>
awaixom
pushed a commit
to awaixom/uniswap-python
that referenced
this pull request
Jul 27, 2026
…/bleach-3.1.4 Bump bleach from 3.0.2 to 3.1.4
This was referenced Jul 28, 2026
ErikBjare
pushed a commit
that referenced
this pull request
Jul 28, 2026
* refactor(tests): replace ganache with anvil for v1-v3 tests Ganache is an npm-maintained tool that has fallen behind foundry's anvil in maintenance and compatibility. Anvil is already used for v4 tests (test_uniswap4.py) and is installed via the foundry-toolchain GitHub Action in CI. - Replace GanacheInstance with AnvilInstance in tests/test_uniswap.py - Swap the ganache fixture for an anvil fixture (same port 10999, Foundry's default test mnemonic account #9 instead of ganache's --wallet.seed account) - Remove `npm install -g ganache@7.5.0` and Node setup from CI workflow - Update README to reference Anvil/Foundry instead of ganache-cli * docs: make Foundry install work in fresh shells * docs: invoke foundryup from installed path * docs: add Foundry binaries to current PATH * fix(tests): pre-populate gas before build_transaction to fix v1 InvalidJump web3.py calls eth_estimateGas internally during build_transaction when no gas field is present in tx_params. Anvil's strict EVM rejects this for Vyper v1 exchange contracts with EVM error InvalidJump (computed jump tables used by old Vyper don't pass strict JUMPDEST validation during simulation). The existing use_estimate_gas=False path set a 250k gas fallback AFTER build_transaction had already made — and failed — the estimateGas call. Fix: pre-populate gas in tx_params before calling build_transaction when use_estimate_gas=False, so web3's internal estimate is never triggered. * test: xfail v1 token-to-ETH cases incompatible with Anvil revm Anvil's revm enforces strict JUMPDEST validation, which rejects the computed jump tables used by old Vyper-compiled Uniswap v1 exchange contracts in the tokenToEth code path (EvmError: InvalidJump). Ganache was more permissive and executed these without error. The ETH-to-token direction works fine; only token-to-ETH triggers the incompatibility. Mark the two failing test cases as xfail so CI is green while keeping the test coverage visible. * test: try 500k gas fallback for v1 token-to-ETH, remove xfail liquid-8 observed out-of-gas in the e792149 CI run rather than a hard InvalidJump at execution. Raise the no-estimate-gas fallback from 250k to 500k — the same direction that resolved similar v4 gas issues — and remove the xfail marks so CI validates the fix directly. If this run still fails, the root cause is confirmed as an EVM bytecode incompatibility rather than insufficient gas, and the xfail approach is the right interim. * test: re-add xfail for v1 token-to-ETH (Anvil revm InvalidJump) 500k gas still hits InvalidJump — it's not a gas issue. Anvil's strict revm rejects the non-standard JUMP patterns in Uniswap v1 Vyper 0.1.x bytecode; Ganache was permissive about these. Gas increase cannot fix this class of failure. xfail on `client.version == 1 and output_token == ETH_ADDRESS` in both test_make_trade and test_make_trade_output, with an explicit reason string pointing at the deprecation track.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps bleach from 3.0.2 to 3.1.4.
Changelog
Sourced from bleach's changelog.
Commits
6e74a50Update for v3.1.4 released6018f2fix bug 1623633fc77027Merge branch 'v3.1.0-branch'e4b1c50Update for v3.1.3 release59cc502Update for v3.1.2 release3f39d48add wheel to requirements-dev175f677fix bug 162169278a0672Update for v3.1.2 release7b625ffadd wheel to requirements-deve4e9e21fix bug 1621692Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labelswill set the current labels as the default for future PRs for this repo and language@dependabot use these reviewerswill set the current reviewers as the default for future PRs for this repo and language@dependabot use these assigneeswill set the current assignees as the default for future PRs for this repo and language@dependabot use this milestonewill set the current milestone as the default for future PRs for this repo and languageYou can disable automated security fix PRs for this repo from the Security Alerts page.