Skip to content

feat: started working on multihop swaps for v3 - #221

Closed
ErikBjare wants to merge 2 commits into
masterfrom
dev/multihop-v3
Closed

feat: started working on multihop swaps for v3#221
ErikBjare wants to merge 2 commits into
masterfrom
dev/multihop-v3

Conversation

@ErikBjare

Copy link
Copy Markdown
Member

Continuing on #110

@codecov

codecov Bot commented Dec 21, 2021

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 58.06452% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.96%. Comparing base (e17818c) to head (2df147d).
⚠️ Report is 52 commits behind head on master.

Files with missing lines Patch % Lines
uniswap/util.py 38.88% 22 Missing ⚠️
uniswap/uniswap.py 84.61% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #221      +/-   ##
==========================================
- Coverage   78.31%   76.96%   -1.36%     
==========================================
  Files          10       10              
  Lines         793      829      +36     
==========================================
+ Hits          621      638      +17     
- Misses        172      191      +19     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This was referenced Dec 21, 2021
@TimeToBuildBob

Copy link
Copy Markdown
Contributor

This 2021 WIP no longer rebases into a coherent feature. Current master has since absorbed the surrounding v2/v3 refactors, while the branch's only surviving conflict-resolved delta is an unused _encode_path helper; v3 multihop quoting and swaps are still not wired or tested. I recommend closing this PR rather than force-pushing a misleading one-function fragment. The remaining feature request is already tracked by #95.

I cannot close or update the org-owned branch from the TimeToBuildBob account because it currently has read-only access to this repository.

@ErikBjare ErikBjare closed this Aug 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants