This repository was archived by the owner on Jul 19, 2022. It is now read-only.
Hashvatar: use background hue for tendrils#305
Merged
Conversation
When picking the tendril color for the `Hashvatar`, pick one in the same hue as the background color. To support this add a `Hue` type to `Color` to help determine what hue a `Color` is in.
pchiusano
approved these changes
Jan 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Hashvatar color picks doesn't result in the most please combinations
Solution
When picking the tendril color for the
Hashvatar, pick one in the samehue as the background color. To support this add a
Huetype toColorto help determine what hue a
Coloris in.