This repository was archived by the owner on Jul 19, 2022. It is now read-only.
Clean AppContext and rename Ucm to Unison Local#280
Merged
Conversation
Move AppContext to its own module (under Env) and rename the Ucm variant to Unison Local so that it matches how we talk about that UI.
|
I'm not Stew but it looks like this would need to change: https://github.com/unisonweb/unison/blob/a6c4533e96ca18286e2cb780f49ab4feff37c7b4/.github/workflows/pre-release.yaml#L36-L37 Edit: Oh and also this: https://github.com/unisonweb/unison/blob/a6c4533e96ca18286e2cb780f49ab4feff37c7b4/.github/workflows/pre-release.yaml#L75-L76 |
Member
Author
|
thanks @ceedubs 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Move AppContext to its own module (under Env) and rename the Ucm variant
to Unison Local so that it matches how we talk about that UI.
Loose ends
This changes one of the artifact (ucm.zip to unisonLocal.zip).
@stew do you know the place that relies on this name for bundling with ucm when we cut releases?