This repository was archived by the owner on Jul 19, 2022. It is now read-only.
Perspective: Improve rendering of very long names#277
Merged
Conversation
Now, with a very long namespace perspective, always ensure that the visual slug is visible and clip the namespace on the left side, favoring the tail end of the namespace: `base.List.NonEmpty` might become `...List.NonEmpty` rather than `base.List.NonE...`.
hojberg
force-pushed
the
fix-namespace-perspective-overflow
branch
from
d820bb8 to
0a43ca5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Now, with a very long namespace perspective, always ensure that the visual slug is visible and clip the namespace on the left side, favoring the tail end of the namespace:
base.List.NonEmptymight become...List.NonEmptyrather thanbase.List.NonE....Fixes #264
Implementation notes
This uses a bit of a hackish way to determine overflow to add a css class, but the low effort compared to alternatives seemed worth it.
Caveats
I also removed the "up" icon for going from a perspective to the root. The user can always just click the top left area (where it says "Unison Share"). I might put the up icon there later on to better indicate this behavior.