Exclude development scripts from published package #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiznich
force-pushed
the
exclude_scripts
branch
from
1184f7e to
1f772e9
Compare
Manishearth
approved these changes
Dec 15, 2025
Manishearth
requested changes
Dec 15, 2025
Member
Manishearth
left a comment
Manishearth
left a comment
There was a problem hiding this comment.
This should still include the tests and benches.
weiznich
force-pushed
the
exclude_scripts
branch
from
1f772e9 to
4914eab
Compare
Manishearth
approved these changes
Dec 16, 2025
Contributor
Author
|
Should I just push a fix for the CI failure as well? |
Member
|
Sure! |
Manishearth
approved these changes
Dec 16, 2025
Member
|
Still fails tests due to an unused import. (Wonder how this at all passed before) |
weiznich
force-pushed
the
exclude_scripts
branch
from
bb823d8 to
1710f19
Compare
Member
|
oy vey. lemme just fix this for you since I can actually have CI run immediately |
Merged
Member
Member
|
Landed, but this branch needs to be updated unfortunately. I can't do this from here since I can't push to this PR, but i can merge once you're done. |
During a dependency review we noticed that the unicode-segmentation crate includes various development scripts. These development scripts shouldn't be there as they might, at some point become problematic. As of now they prevent any downstream user from enabling the `[bans.build.interpreted]` option of cargo deny. I opted for using an explicit include list instead of an exclude list to prevent these files from beeing included in the published packages to make sure that everything that's included is an conscious choice.
weiznich
force-pushed
the
exclude_scripts
branch
from
1710f19 to
65d9c14
Compare
Contributor
Author
|
Thanks for the help 🙏 |
Manishearth
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During a dependency review we noticed that the unicode-segmentation crate includes various development scripts. These development scripts shouldn't be there as they might, at some point become problematic. As of now they prevent any downstream user from enabling the
[bans.build.interpreted]option of cargo deny.I opted for using an explicit include list instead of an exclude list to prevent these files from beeing included in the published packages to make sure that everything that's included is an conscious choice.