Fixup package #123
Fixup package #123
Conversation
Cargo.toml
Outdated
| """ | ||
|
|
||
| exclude = [ "target/*", "Cargo.lock", "scripts/tmp", "benches/texts/*", "*.txt", ] | ||
| exclude = ["/.github", "/scripts", "/benches/texts"] |
There was a problem hiding this comment.
I'd rather not exclude scripts, it's not used by the Rust package but people vendoring the crate sometimes care about having files like this. Can this be reverted to excluding scripts/tmp?
There was a problem hiding this comment.
Ahh ok, that's unfortunate, the main motivation for the change was to remove executable scripts, but I'll revert that part.
There was a problem hiding this comment.
What's the reason for removing executable scripts? In general I'm 100% sympathetic to the idea that one shouldn't ship unnecessary executables (and I'm aware of the recent kerfuffle in the broader community), but in this case (1) they're scripts, so they're easy to inspect and compare against the git history, and (2) they are not, to my knowledge, executed automatically under any circumstances.
There was a problem hiding this comment.
@Jake-Shadle if they have an executable bit set I do not mind removing that, but it's not a huge deal. They are scripts, not binaries.
|
Thanks! |
3 participants
This fixes up the
package.excludefield to be simpler and actually exclude everything that is unused for downstream users, notably the entirety of thescriptsfolder. Thetarget/*andCargo.lockvalues were superfluous since they are already present in the .gitignore which cargo excludes by default.While I was doing this I noticed that github CI was now used, but the .travis.yml file was still in the root, and the README still used the travis badge, so fixed that.