Add "opt-out" test gating for vendors, document getting working tests #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hopefully this provides the best of all worlds. Importantly, this re-introduces src/test.rs, as that's something that can't be trivially generated. Both approaches are documented so the path to the easiest working solution is clear for vendors, and they can pick either the more expensive solution, or the simpler (but less comprehensive) one. If this PR meets general approval, I'd like to add a .travis.yml step that automatically tests the --cfg minimal_tests path, so at least, that will be a "stable" target, as testing that the deployed crate is free from errors is presently too much work to expect the average maintainer or contributor to remember to do. Closes: unicode-rs#38
Member
|
I think this approach is okay. Adding the travis entry also sounds good. An alternate approach that might be better for you would be to move stuff into Up to you, both approaches seem fine to me, but the latter means that you don't need special instructions for running the tests. |
This is still just a work-in-progress, so may be rebased-out in future, just seeing if it Works yet before I spend time on something potentially more finely grained.
Contributor
Author
|
Self closing as is subsumed by #48 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this provides the best of all worlds.
Importantly, this re-introduces src/test.rs, as that's something that
can't be trivially generated.
Both approaches are documented so the path to the easiest working
solution is clear for vendors, and they can pick either the more
expensive solution, or the simpler (but less comprehensive) one.
If this PR meets general approval, I'd like to add a .travis.yml
step that automatically tests the --cfg minimal_tests path, so at
least, that will be a "stable" target, as testing that the deployed
crate is free from errors is presently too much work to expect the
average maintainer or contributor to remember to do.
Closes: #38