Inflection-179: Update ICU dependency and Wikidata processing #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grhoten
commented
Dec 15, 2025
| TEST_CASE("NumberConceptTest#testSwiss") | ||
| { | ||
| REQUIRE(u"1’000" == ::inflection::dialog::NumberConcept((int64_t)1000, ::inflection::util::LocaleUtils::SWITZERLAND_GERMAN(), ::inflection::util::LocaleUtils::SWITZERLAND_GERMAN()).getAsDigits().getPrint()); | ||
| REQUIRE(u"1'000" == ::inflection::dialog::NumberConcept((int64_t)1000, ::inflection::util::LocaleUtils::SWITZERLAND_GERMAN(), ::inflection::util::LocaleUtils::SWITZERLAND_GERMAN()).getAsDigits().getPrint()); |
Member
Author
There was a problem hiding this comment.
Required by ICU 78.1 used by macOS GitHub action.
| auto numID = npc(inflectionDictionary)->getId(value); | ||
| if (numID == -1) { | ||
| throw inflection::exception::IllegalStateException(std::u16string(value) + u" inflection name not found."); | ||
| } |
Member
Author
There was a problem hiding this comment.
Safety check in case things get out of sync.
| TYPEMAP.put("Q3734650", EnumSet.of(Ignorable.IGNORABLE_LEMMA)); // adverbial phrase, a phrase the head of which is an adverb | ||
| TYPEMAP.put("Q357760", EnumSet.of(Ignorable.IGNORABLE_LEMMA)); // adjectival phrase | ||
| TYPEMAP.put("Q56042915", EnumSet.of(Ignorable.IGNORABLE_LEMMA)); // prepositional phrase | ||
| TYPEMAP.put("Q3397768", EnumSet.of(Ignorable.IGNORABLE_LEMMA)); // prepositional phrase/prepositional syntagma |
Member
Author
There was a problem hiding this comment.
This got renamed in Wikidata.
| # | ||
| CATCH2_VERSION := 3.9.0 | ||
| ICU_VERSION_MINIMUM := 77.1 | ||
| ICU_VERSION_MINIMUM := 78.1 |
Member
Author
There was a problem hiding this comment.
Get Linux and macOS to use the same version.
Contributor
|
The github workflow is installing ICU of 77.1 release that is why this is occurring, please consider updating |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #179