Skip to content

Conversation

@srl295
Copy link
Member

@srl295 srl295 commented Aug 24, 2019

ARchive of icu4j applets

@srl295 srl295 self-assigned this Aug 24, 2019
@srl295 srl295 requested review from sffc and removed request for aheninger September 24, 2019 23:27
@srl295
Copy link
Member Author

srl295 commented Sep 24, 2019

archival purposes…

@sffc
Copy link
Member

sffc commented Sep 25, 2019

Thanks; how should I review this PR?

@srl295
Copy link
Member Author

srl295 commented Sep 25, 2019

Thanks; how should I review this PR?

as it says in the diff, this is an archive of a zipfile that was on the old site … https://github.com/unicode-org/icu-demos/pull/5/files#diff-82113023f0e67349043e02e83a06fee9R4

you can review it as to whether it should be included. I don't know where the source to these applets are.

Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@sffc sffc removed their request for review September 25, 2019 21:43
@sffc sffc removed their assignment Sep 25, 2019
@sffc
Copy link
Member

sffc commented Sep 25, 2019

I'll defer to Markus on this as I don't know the history of these applets either.

@srl295 srl295 merged commit 15512a9 into master Sep 25, 2019
@srl295 srl295 deleted the icu4j-applets branch September 25, 2019 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants