CLDR-18099 Add a few more European Englishes #4302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AEApple
added a commit
that referenced
this pull request
Jan 22, 2025
AEApple
force-pushed
the
AEApple-CLDR-18099-2
branch
from
e71d5dc to
cc066ee
Compare
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
See #4302 Adding a few more European Englishes and updating en_FR for consistency with approach to other en_150 child locales.
AEApple
force-pushed
the
AEApple-CLDR-18099-2
branch
from
a45c912 to
59a9f67
Compare
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
AEApple
requested review from
conradarcturus,
macchiati,
pedberg-icu and
srl295
CLDR-18099 Fix xml error
srl295
reviewed
Jan 22, 2025
common/main/en_FR.xml
Outdated
| <numbers> | ||
| <symbols numberSystem="latn"> | ||
| <decimal>,</decimal> | ||
| <group> </group> |
There was a problem hiding this comment.
error here. is this supposed to be a different kind of space? fr.xml has NNBSP
There was a problem hiding this comment.
Is there a reason this doesn't get fixed during DAIP? I can go through and fix all the spaces to NNBSP, but it seems like something that DAIP would resolve?
There was a problem hiding this comment.
It gets collapsed to <group></group> or <group/> without xml:space="preserve" so the parser sees a 0-length group string. Probably better to fix it here.
CLDR-18099 Fix error
srl295
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-18099
and update en_FR for consistency with the approach for other en_150 child locales.
ALLOW_MANY_COMMITS=true