Skip to content

Conversation

@conradarcturus
Copy link
Contributor

@conradarcturus conradarcturus commented Oct 29, 2024

#4069 got erased when merging v47 back to main so I'm creating a new pull request.

These two island communities don't have a permanent population but they have a top-level internet domain and they usually are inhabited by people speaking English or Norwegian.

Need to also Adding en_GS.xml that inherits from en_001 since en_GS is an official language technically

CLDR-9791

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

These two island communities don't have a permanent population but they have a top-level internet domain and they usually are inhabited by people speaking English or Norwegian.

CLDR-9791 Add en_GS.xml

Adding en_GS.xml that inherits from en_001
@conradarcturus conradarcturus requested review from btangmu, macchiati and srl295 and removed request for macchiati October 29, 2024 17:16
zh-Hans-fonipa; chinšćina [zjednorjena] (FONIPA)


@locale=ht
Copy link
Contributor Author

@conradarcturus conradarcturus Oct 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Haitian Creole data here is added because it wasn't added when the locale xml was added. It was generated by the automated script that I run to rebuild files that inherit from the population data.

mvn package -DskipTests=true && java -jar tools/cldr-code/target/cldr-code.jar ConvertLanguageData && java -jar tools/cldr-code/target/cldr-code.jar GenerateLikelySubtags && java -jar tools/cldr-code/target/cldr-code.jar GenerateTestData

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine, of course test data is generated as part of the BRS cycle, it does not strictly need to be added when the locale was added.

zh-Hans-fonipa; chinšćina [zjednorjena] (FONIPA)


@locale=ht
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine, of course test data is generated as part of the BRS cycle, it does not strictly need to be added when the locale was added.

@conradarcturus conradarcturus merged commit 959045e into unicode-org:main Oct 30, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants