first#2

Open

FangyuanZ wants to merge 1 commit intounibit-api:masterfrom

FangyuanZ:master

FangyuanZ commented Apr 5, 2019

No description provided.


          first

423e27f

Contributor

sgrosser commented Apr 8, 2019

Could you use the python-unibit SDK in this example?

Contributor

sgrosser commented Apr 8, 2019

As well, be sure when you submit a pull request to leave API keys as parameters. You don't want to put your own API key into the example!

Author

FangyuanZ commented Apr 8, 2019 via email

Hi Stefan, I would do it as soon as possible. Thank you. Fangyuan On Apr 8, 2019, at 14:32, Stefan Grosser <notifications@github.com<mailto:notifications@github.com>> wrote: Could you use the python-unibit<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_unibit-2Dapi_python-2Dunibit&d=DwMCaQ&c=imBPVzF25OnBgGmVOlcsiEgHoG1i6YHLR0Sj_gZ4adc&r=Q8y8ejcBRT8ElJslHEWycw&m=Lt-YDr4fxvYHuDCTn7GUm1d69B8_sNGukXQlkSQlBK4&s=5lJuFQEGun2yJIdc0me3bGuEfyvW-LphuxOzpmNV5sY&e=> SDK in this example? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_unibit-2Dapi_unibit-2Dexamples_pull_2-23issuecomment-2D480951455&d=DwMCaQ&c=imBPVzF25OnBgGmVOlcsiEgHoG1i6YHLR0Sj_gZ4adc&r=Q8y8ejcBRT8ElJslHEWycw&m=Lt-YDr4fxvYHuDCTn7GUm1d69B8_sNGukXQlkSQlBK4&s=8cgKS2GNaopTZ2C8CIWoY136p3YfDJW3MAR6Uu4ojtI&e=>, or mute the thread<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AsEUbbay0r3GKp4Degni5-2Dodus-2DykOBQks5ve4tOgaJpZM4cfwuC&d=DwMCaQ&c=imBPVzF25OnBgGmVOlcsiEgHoG1i6YHLR0Sj_gZ4adc&r=Q8y8ejcBRT8ElJslHEWycw&m=Lt-YDr4fxvYHuDCTn7GUm1d69B8_sNGukXQlkSQlBK4&s=wz1oL-u6op9YMkrg5jXRYP-nYj7CqnDptxvgIa2sXN0&e=>.

Author

FangyuanZ commented Apr 8, 2019 via email

Hi Stefan, I have uploaded the new version and made the new pull request. Thank you for your time. Best, Fangyuan On Apr 8, 2019, at 14:36, Stefan Grosser <notifications@github.com<mailto:notifications@github.com>> wrote: As well, be sure when you submit a pull request to leave API keys as parameters. You don't want to put your own API key into the example! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_unibit-2Dapi_unibit-2Dexamples_pull_2-23issuecomment-2D480952799&d=DwMCaQ&c=imBPVzF25OnBgGmVOlcsiEgHoG1i6YHLR0Sj_gZ4adc&r=Q8y8ejcBRT8ElJslHEWycw&m=o3zD8RsAueX1Gh8IOIu1H4tspeS5DibZB5BRPdfubq4&s=vU8IeYKkwdu6Pzm9WbAB3MAHedmN-Dr5-Pj1Agvfcrw&e=>, or mute the thread<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AsEUbVTSsMNSzO5k5e56-5FwPaGyBQ6y6mks5ve4wjgaJpZM4cfwuC&d=DwMCaQ&c=imBPVzF25OnBgGmVOlcsiEgHoG1i6YHLR0Sj_gZ4adc&r=Q8y8ejcBRT8ElJslHEWycw&m=o3zD8RsAueX1Gh8IOIu1H4tspeS5DibZB5BRPdfubq4&s=2PLrG1P6CskUymIKL4tE-sKDP6-KcKu9FBKgw4yjUBE&e=>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet