i hate this constructor.. bad design

benfry · benfry · commit fe6c11bda3c2 · 2015-08-22T16:13:08.000-04:00
diff --git a/app/src/processing/app/ui/Editor.java b/app/src/processing/app/ui/Editor.java
@@ -433,7 +433,8 @@ public void processKeyEvent(KeyEvent evt) {
 
   public EditorFooter createFooter() {
     EditorFooter ef = new EditorFooter(this);
-    addConsole();  // console is required
+    console = new EditorConsole(this);
+    ef.addPanel(console, Language.text("editor.footer.console"), "/lib/footer/console");
     return ef;
 
     /*
@@ -456,13 +457,7 @@ public EditorFooter createFooter() {
   }
 
 
-  public void addConsole() {
-    console = new EditorConsole(this);
-    footer.addPanel(console, Language.text("editor.footer.console"), "/lib/footer/console");
-  }
-
-
-  public void addErrorTable() {
+  public void addErrorTable(EditorFooter footer) {
     JScrollPane errorTableScrollPane = new JScrollPane();
     errorTable = new ErrorTable(this);
     errorTableScrollPane.setBorder(BorderFactory.createEmptyBorder());
