Only enqueue jQuery if Bootstrap version = 4#1760
Open
bbbenji wants to merge 1 commit intounderstrap:developfrom
Open
Only enqueue jQuery if Bootstrap version = 4#1760bbbenji wants to merge 1 commit intounderstrap:developfrom
bbbenji wants to merge 1 commit intounderstrap:developfrom
Conversation
Member
|
I haven't tested this out yet, but in theory this should be fine. Other plugins and child themes can still load jQuery if they need it- the starter child theme does... I'll run some tests, but open to discussion from anyone who sees any issues here, as this technically would be a change for sites that are live with BS5 and the parent theme active. |
Contributor
|
I am in favor of this change. However, this is a breaking change and I suggest to wait for other breaking changes in order to minimize the number of breaking changes. |
Contributor
|
The hero slider uses jQuery. I made a PR removing jQuery. See #1840 |
Member
|
The more I think about this, the more I think it's a good thing:
Still leaving this open for comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Only enqueue jQuery if Bootstrap version = 4
Motivation and Context
Bootstrap 5 no longer requires jQuery. This change only enqueues jQuery, if Bootstrap 4 is selected.
Types of changes
Checklist:
develop.develop.composer cs:checkhas passed locally.composer lint:phphas passed locally.