Repository navigation
Conversation
acassis
requested review from
PoeticPeteAdmin,
gmaurel,
micheleCTDEAdmin and
mwoehlke-kitware
as code owners
July 17, 2026 18:57
acassis
commented
Jul 17, 2026
I think uncrustify is the only lint/formatter able to fix almost 95% of source code to fit the NuttX coding style. But there is not support to add new line after a comment line: /* This is a single line comment */ bool code_need_empty_line_after_comment = true; shold be converted to: /* This is a single line comment */ bool code_need_empty_line_after_comment = true; Signed-off-by: Alan C. Assis <acassis@gmail.com>
acassis
force-pushed
the
add_nl_after_comment
branch
from
July 17, 2026 19:09
114bb62 to
1df81ac
Compare
Author
|
ping @gmaurel |
Collaborator
|
@acassis please fix the failing tests. Also note that when you add a new option, there are a number of files that need to be updated. You can look where other options are used and do the same for the new option. Alternatively you can use the |
Collaborator
|
@acassis |
Author
Hi @gmaurel basically this: https://nuttx.apache.org/docs/latest/contributing/coding_style.html#comments We need a rule to add a NL after a single comment. For multi-line comments there is already a rule to force a NL, but not for single line. |
Collaborator
|
@acassis can you look at the failing tests? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Uncrustify team,
I think uncrustify is the only lint/formatter able to fix almost 95% of source code to fit the NuttX coding style:
https://nuttx.apache.org/docs/latest/components/tools/uncrustify.html
But it doesn't support to add a new line after a comment line:
/* This is a single line comment */
bool code_need_empty_line_after_comment = true;
shold be converted to:
/* This is a single line comment */
bool code_need_empty_line_after_comment = true;