Skip to content

introduce CT_BITWISE_AND as CT_ARITH - #4510

Open
guy-maurel wants to merge 1 commit into
uncrustify:masterfrom
guy-maurel:CT_ADDR
Open

guy-maurel wants to merge 1 commit into
uncrustify:masterfrom
guy-maurel:CT_ADDR

Conversation

@guy-maurel

@guy-maurel guy-maurel commented Apr 28, 2025 •

Copy link
Copy Markdown
Contributor

PR #4510 is a bug fix proposal.
Please test it and report.
for the Issues #4505, #4502, #2205

@briggsywxf

Copy link
Copy Markdown

Unfortunately this seems to not fix the issue in #4502 . The line in question is still formatted as if ((flags& MyEnum::FlagA) != MyEnum::Null) .
The parsing dump output also shows that the & is still parsed as a byref inside a c_cast, so it doesn't seem to be an issue with the config. Perhaps due to flags being parsed as TYPE even when it isn't and then we hit the assignment at line 1337 in these changes so the & is still set to CT_ADDR.

Is it worth adding the example given in #4502 as a test case? I can write it up properly as an additional test if needed.

@guy-maurel

Copy link
Copy Markdown
Contributor Author

I look...
Some more test data is always welcome!
Thanks

@briggsywxf

briggsywxf commented Apr 30, 2025 •

Copy link
Copy Markdown

I look... Some more test data is always welcome! Thanks

I'll add a test and open it as a PR into this one

Edit: couldn't base it on this PR because it's coming from a fork too, but test at #4513

@maxbachmann

Copy link
Copy Markdown

Any chance t get this fixes? Or is there a deeper problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants