Skip to content

Commit 2ddd61a

Browse files
authored
Merge pull request cli#795 from cli/contributing-docs
Tweak CONTRIBUTING docs to clarify our stance about installation instructions
2 parents 664d250 + 206cff9 commit 2ddd61a

File tree

1 file changed

+22
-7
lines changed

1 file changed

+22
-7
lines changed

.github/CONTRIBUTING.md

Lines changed: 22 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,21 +12,36 @@ Please do:
1212

1313
* open an issue if things aren't working as expected
1414
* open an issue to propose a significant change
15-
* open a PR to fix a bug
16-
* open a PR if a member of the GitHub CLI team has given the ok after discussion in an issue
15+
* open a pull request to fix a bug
16+
* open a pull request to fix documentation about a command
17+
* open a pull request if a member of the GitHub CLI team has given the ok after discussion in an issue
18+
19+
Please avoid:
20+
21+
* adding installation instructions specifically for your OS/package manager
22+
23+
## Building the project
24+
25+
Prerequisites:
26+
- Go 1.13
27+
28+
Build with: `make` or `go build -o bin/gh ./cmd/gh`
29+
30+
Run the new binary as: `./bin/gh`
31+
32+
Run tests with: `make test` or `go test ./...`
1733

1834
## Submitting a pull request
1935

20-
0. Clone this repository
21-
0. Create a new branch: `git checkout -b my-branch-name`
22-
0. Make your change, add tests, and ensure tests pass
23-
0. Make a PR: `gh pr create --web`
36+
1. Create a new branch: `git checkout -b my-branch-name`
37+
1. Make your change, add tests, and ensure tests pass
38+
1. Submit a pull request: `gh pr create --web`
2439

2540
Contributions to this project are [released][legal] to the public under the [project's open source license][license].
2641

2742
Please note that this project adheres to a [Contributor Code of Conduct][code-of-conduct]. By participating in this project you agree to abide by its terms.
2843

29-
We generate manual pages from source on every release! You do not need to submit PRs for those specifically; the docs will get updated if your PR gets accepted.
44+
We generate manual pages from source on every release. You do not need to submit pull requests for documentation specifically; manual pages for commands will automatically get updated after your pull requests gets accepted.
3045

3146
## Resources
3247

0 commit comments

Comments
 (0)