fix: run build on CI unconditionally #2
Conversation
🦋 Changeset detectedLatest commit: 715f644 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Caution Review failedThe pull request is closed. WalkthroughAdds a new changeset for a patch release message and updates the release GitHub Actions workflow to always run a build by inserting an explicit “npm run build” step between dependency installation and publishing. No source code or public API changes. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Dev as Developer
participant GH as GitHub Actions (release.yml)
participant NPM as npm Registry
Dev->>GH: Push tag / trigger release workflow
GH->>GH: Checkout code
GH->>GH: Setup Node & install dependencies
note over GH: New step
GH->>GH: Run build (npm run build)
GH->>NPM: Publish package
NPM-->>GH: Publish result
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Signed-off-by: JounQin <admin@1stg.me>
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 6ae7af5 in 17 seconds. Click for details.
- Reviewed
14lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .github/workflows/release.yml:32
- Draft comment:
Unconditionally running the build step looks correct for releasing. Ensure the build output is as expected for your publish step. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_pZWQzUUHHZjX6Bpc
You can customize 
Important
Add a
Buildstep to the CI workflow inrelease.ymlto runnpm run buildunconditionally before publishing.Buildstep in.github/workflows/release.ymlto runnpm run buildunconditionally before publishing to npm.This description was created by
for 6ae7af5. You can customize this summary. It will automatically update as commits are pushed.
Summary by CodeRabbit
Chores
Bug Fixes