Correct detection of anterior tenses

lenka-krippnerova · lenka-krippnerova · commit 21649d788a01 · 2025-11-19T17:49:23.000+01:00
diff --git a/udapi/block/msf/romance/romance.py b/udapi/block/msf/romance/romance.py
@@ -7,6 +7,7 @@
           'potere', 'dovere', 'volere', 'sapere'] # Italian
 
 class Aspect(str, Enum):
+    ANT = 'Ant'
     IMP = 'Imp'
     IMPPROG = 'ImpProg'
     PERF = 'Perf'
@@ -523,10 +524,22 @@ def process_periphrastic_verb_forms(self, node, auxes, expl, polarity, phrase_or
 
                 # Italian
                 # Trapassato prossimo -> PhraseTense=Past, PhraseAspect=Pqp
-                elif auxes[0].feats['Tense'] in ['Imp', 'Past']: # TODO prej neni v Past, jenom Imp
+                elif auxes[0].feats['Tense'] == 'Imp':
                     tense=Tense.PAST.value
                     aspect=Aspect.PQP.value
 
+                # Spanish
+                # pretérito anterior ante pretérito -> PhraseTense=Past, PhraseAspect=Ant
+
+                # Italian
+                # trapassato remoto -> PhraseTense=Past, PhraseAspect=Ant
+                
+                # French
+                # passé antérieur -> PhraseTense=Past, PhraseAspect=Ant
+                elif auxes[0].feats['Tense'] == 'Past':
+                    tense=Tense.PAST.value
+                    aspect = Aspect.ANT.value
+
                 self.write_node_info(head_node,
                     tense=tense,
                     number=auxes[0].feats['Number'],
@@ -709,4 +722,4 @@ def process_copulas(self, node, cop, expl, polarity, phrase_ords):
             if cop[0].lemma == 'ser':
                 node.misc['PhraseAspect'] = Aspect.PERF.value
             elif cop[0].lemma == 'estar':
-                node.misc['PhraseAspect'] = Aspect.IMP.value
+                node.misc['PhraseAspect'] = Aspect.IMP.value
