Skip to content

remove dependency for slices package #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wangrzneu merged 5 commits into from
May 8, 2024
Merged

remove dependency for slices package #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6cb2915
update golang version in github action
wangrzneu May 7, 2024
c9385b4
update build version
wangrzneu May 8, 2024
47fccce
remove dependency for slices package
wangrzneu May 8, 2024
bfc96df
update golang build env version
wangrzneu May 8, 2024
2117c5b
Merge branch 'master' into master
wangrzneu May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
- name: Set up go
uses: actions/setup-go@v3
with:
go-version: 1.20.14
go-version: 1.19.2

- name: Build
run: bash hack/github-release.sh
Expand Down
12 changes: 10 additions & 2 deletions cmd/api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import (
"fmt"
"io"
"io/ioutil"
"slices"
"strconv"
"strings"
"sync"
Expand Down Expand Up @@ -50,7 +49,7 @@ func NewCmdAPI(out io.Writer) *cobra.Command {
Short: "Call API",
Long: "Call API",
Run: func(c *cobra.Command, args []string) {
if slices.Contains(args, "--help") {
if containHelp(args) {
fmt.Fprintln(out, HelpInfo)
return
}
Expand Down Expand Up @@ -251,3 +250,12 @@ func genericInvokeRepeatWrapper(repeatsConfig *RepeatsConfig, params map[string]
refresh.Do(fmt.Sprintf("finally, total:%d, success:%d, fail:%d", repeats, success.Load(), repeats-int(success.Load())))
return nil
}

func containHelp(args []string) bool {
for _, arg := range args {
if arg == "--help" {
return true
}
}
return false
}
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/ucloud/ucloud-cli

go 1.20
go 1.19

require (
github.com/fatih/color v1.13.0
Expand Down