Remove UserAgentParser.parse #14

Activity

1. wallin commented on Jun 13, 2017

   

   wallin

   on Jun 13, 2017

   Contributor

   More actions

   @toolmantim Is this still relevant?
2. soulcutter commented on Sep 16, 2021

   

   soulcutter

   on Sep 16, 2021

   More actions

   @wallin This is still relevant. We hit this footgun using the class method in a rails request - loading the yaml and compiling the regexes on every request. This added about 40-50ms per-request, which is quite unexpected and one of those things that's really easy to miss when you first introduce using this gem - though I appreciate the readme does attempt to address it.

   If the docs clearly stated "Expect this method to take 50ms" I suspect nobody would use it. I support this issue.
3. AxelTheGerman commented on Oct 19, 2023

   

   AxelTheGerman

   on Oct 19, 2023

   More actions

   First step could be to add a deprecation warning maybe? That could already educate and also help transition.